Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: enable lz4 compression #819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zfs: enable lz4 compression #819

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Collaborator

@Mic92 Mic92 commented Oct 4, 2024 •
edited
Loading

This should speed up image creation but also in my experience lz4 compression usually easily keeps up with NVME storage bandwidth so in turn it boost IO performance

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
    This change would require a full installation. However only if you want to benefit from the effect. It's also possible to enable lz4 at runtime and only use it for new blocks.
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@Mic92 Mic92 temporarily deployed to internal-build-workflow October 4, 2024 09:27 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow October 4, 2024 09:27 — with GitHub Actions Inactive
@Mic92
zfs: enable lz4 compression
ba89c62 
This should speed up image creation but also in my experience lz4
compression usually easily keeps up with NVME storage bandwidth
boosting overall IO performance.

Signed-off-by: Jörg Thalheim <[email protected]>
@Mic92 Mic92 temporarily deployed to internal-build-workflow October 4, 2024 09:27 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow October 4, 2024 09:28 — with GitHub Actions Inactive
@Mic92
Copy link
Collaborator Author

Mic92 commented Oct 4, 2024

My personal motivation for this usually is that I can store more data. I believe there were performance benchmarks in this repository as well? Might be good to apply them to this change.

@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Testing CI Team to pre-verify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @brianmcgillion